Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex package cleanup #122

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Hex package cleanup #122

merged 2 commits into from
Feb 19, 2024

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Feb 19, 2024

Description

This PR cleans the helper/hex package and adds UTs so that coverage is 100%.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal added the technical-debt Removal of technical debt label Feb 19, 2024
@goran-ethernal goran-ethernal self-assigned this Feb 19, 2024
@goran-ethernal goran-ethernal merged commit 9be4332 into develop Feb 19, 2024
8 of 9 checks passed
@goran-ethernal goran-ethernal deleted the hex-package-cleanup branch February 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Removal of technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants