Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pooling of big.Int instances in the EVM #124

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Pooling of big.Int instances in the EVM #124

merged 4 commits into from
Feb 21, 2024

Conversation

cokicm
Copy link

@cokicm cokicm commented Feb 19, 2024 •
edited by Stefan-Ethernal
Loading

Description

This PR contains the following changes:

  • Pooling of big.Int instances on the stack to avoid frequent allocations/cleanup
  • Removing unnecessary big.Int allocation in pop() method and fixing tests
  • Avoiding unnecessary op.String() calls when tracer is not initialized.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@cokicm
Multiple performance improvements:
2d16d8a 
- Pooling of big.Int instances on the stack to avoid frequent allocations/cleanup
- Removing unnecessary big.Int allocation in pop() method and fixing tests
- Avoiding unnecessary op.String() calls when tracer is not initialized.
@cokicm cokicm self-assigned this Feb 19, 2024
goran-ethernal
goran-ethernal previously approved these changes Feb 19, 2024
View reviewed changes
@goran-ethernal goran-ethernal added the performance-improvements Performance improvements label Feb 20, 2024
goran-ethernal
goran-ethernal previously approved these changes Feb 20, 2024
View reviewed changes
@Stefan-Ethernal Stefan-Ethernal changed the title Multiple performance improvements: Pooling of big.Int instances in the EVM Feb 21, 2024
@Stefan-Ethernal Stefan-Ethernal merged commit f2b212e into develop Feb 21, 2024
8 of 9 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the performance-improvements branch February 21, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@cokicm cokicm

Labels
performance-improvements Performance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cokicm @Stefan-Ethernal @goran-ethernal