Add read threads to storagev2 leveldb unit test #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require.NoError(t, batchWriter.WriteBatch()) | ||
|
|
||
| size := dirSize(t, path) | ||
| writeBlock(t, s, b) |
There was a problem hiding this comment.
Is writing blocks also a thread-safe operation? I'm aware that in the practice, there shouldn't be multiple writers, but however, if it is a thread-safe operation it would be nice to have a test where there are multiple readers and writers in parallel.
There was a problem hiding this comment.
Request was to have one thread to write into database and multiple concurrent readers, which should correspond to real use case.
Stefan-Ethernal
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit test for storagev2 levekdb has been modified to have threads reading database in parallel.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it