Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust round 0 timeout for go-ibft #204

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

Stefan-Ethernal
Copy link

@Stefan-Ethernal Stefan-Ethernal commented Apr 22, 2024

Description

In case block time is greater than or equal to default base round timeout, that is 10s, base round timeout is determined as twice the block time.

  • adjust round 0 timeout if block time is changed through governance.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/adapt-round0-timeout-to-block-time branch from 91bfd76 to 4cc8a5f Compare April 22, 2024 12:42
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/adapt-round0-timeout-to-block-time branch from 993d0f2 to d3ceeaf Compare April 25, 2024 08:49
@Stefan-Ethernal Stefan-Ethernal merged commit ec98fb4 into develop Apr 26, 2024
10 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the feat/adapt-round0-timeout-to-block-time branch April 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants