Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP1559 token burning fix #209

Merged
merged 2 commits into from
Apr 24, 2024
Merged

EIP1559 token burning fix #209

merged 2 commits into from
Apr 24, 2024

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Apr 24, 2024

Description

Tokens on blade should be transferred to the burn contract only when London (EIP1559) fork is active and blade is acting as an L2, where native token is originated from a L1 chain. In that case, burned tokens need to be transferred to some contract (burn contract), from which they can be transferred back to the L1.

In cases where blade is acting as L1 or if it is acting as L2, but its native token is mintable, then, burning happens in the evm as is. Meaning, tokens that will be burned, won't be transferred to any contract or address, making them "dissappear" from circulation forever.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal added the bug-fix Fix for a bug label Apr 24, 2024
@goran-ethernal goran-ethernal requested a review from a team April 24, 2024 12:02
@goran-ethernal goran-ethernal self-assigned this Apr 24, 2024
state/executor.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal merged commit dc77972 into develop Apr 24, 2024
10 checks passed
@goran-ethernal goran-ethernal deleted the burn-fix branch April 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants