-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for txpool loosing txs #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some small comments, but in general LGTM.
Can we add some unit tests for this? It looks like it can be easily tested in various scenarios on the txpool and account level. |
Yes, 4 UTs have been added to txpool UTs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, left a couple of considerations.
Description
During proposal build a proposer removes txs from the accounts.promoted with accounts.promoted.pop. That leads to possible problem because those txs are permanently removed and in the case if that round fails the proposer can't take part in the consensus and further more there is a high possibility of nonce too high error for future proposals on that particular validator.
Changes include
Checklist
Testing
Manual tests
Run EOA load test in local.