Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e fixes #238

Merged
merged 2 commits into from
May 14, 2024
Merged

e2e fixes #238

merged 2 commits into from
May 14, 2024

Conversation

oliverbundalo
Copy link

@oliverbundalo oliverbundalo commented May 14, 2024

Description

Fix for TestE2E_Bridge_ChildchainTokensTransfer because it can't pass in attempts after the 1st one.
NonMintableERC20 is changed to take epochs into account instead of sprints because commitment is built at the epoch end. We need this because test fails occasionally due to slow CI instance. If we give more chances for test to pass it is expected to be greener, as it is for the same ERC721 test which is 100% green. In the worst negative scenario we will wait for 30 seconds longer than before. In the positive case an average duration time should be similar as it was before, but this gives at least 1 or 2 epoch commitments more and that increases the chance for positive outcome.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@oliverbundalo oliverbundalo added the tests Add, update or removal of tests label May 14, 2024
@oliverbundalo oliverbundalo self-assigned this May 14, 2024
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
@oliverbundalo oliverbundalo merged commit 4f18bea into develop May 14, 2024
10 checks passed
@oliverbundalo oliverbundalo deleted the enh/e2e-fixes branch May 14, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add, update or removal of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants