Add blade admin flag #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
add-blade-admin-flag
branch
from
23fc70d to
dddd843
Compare
goran-ethernal
requested review from
Stefan-Ethernal and
dusannosovic-ethernal
goran-ethernal
changed the base branch from
develop
to
fix/remove-is-mintable-native-token
Stefan-Ethernal
approved these changes
Nov 28, 2023
goran-ethernal
merged commit 89a152a
into
fix/remove-is-mintable-native-token
5 of 7 checks passed
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Nov 28, 2023
* Introduce blade admin * Move to the newest main branch on contracts * Remove NativeTokenConfig from e2e tests * Comments fix
goran-ethernal
added a commit
that referenced
this pull request
Nov 28, 2023
* Introduce blade admin * Move to the newest main branch on contracts * Remove NativeTokenConfig from e2e tests * Comments fix
goran-ethernal
added a commit
that referenced
this pull request
Nov 28, 2023
* Remove IsMintable native token flag * Remove key from PremineInfo * Add blade admin flag (#24) * Introduce blade admin * Move to the newest main branch on contracts * Remove NativeTokenConfig from e2e tests * Comments fix --------- Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com>
goran-ethernal
added a commit
that referenced
this pull request
Dec 6, 2023
* apply patch * Fix for unit tests * lint fix * lint fix * contracts fix * makefile fix * build fix * fix some imports * Lint fix * comment fixs * fix imports * Update command/genesis/genesis.go Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * Update command/genesis/params.go Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * fix comments * Linter fixes * deleted supernet package * stake fix * stake fix 2 * comments fix * Use new version of contracts * Remove RewardPool address and rename ValidatorSet address to EpochManager address * Remove burn contract flag * Remove non-mintable configuration in genesis * Lint fixes * Minor rename * Update e2e-polybft/e2e/consensus_test.go Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * Fix comment * bridge commands relocation (#19) * bridge commands relocation * mint command relocation * un/stake and whitelist from sidechain to validator folder * sidechain commands relocation * commands relocation * deleted license * build fix * Build fix * segmentation fault fix * added nativeERC20 approve * command fix --------- Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> * Remove IsMintable native token flag (#22) * Remove IsMintable native token flag * Remove key from PremineInfo * Add blade admin flag (#24) * Introduce blade admin * Move to the newest main branch on contracts * Remove NativeTokenConfig from e2e tests * Comments fix --------- Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com> * UT fix (#25) * Add default premine for validators (#26) * Fix consensus `e2e` tests (#28) * Fix e2e tests * Fix migration e2e test (#30) * Remove StakeManagerAddr, StakeTokenAddr and CustomSupernetManagerAddr from bridge config * Fix integration test (#31) * Fix fund command UT * Small fixes --------- Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> * Small fixes for e2e tests * Move and modify `ChangeVotingPower` `e2e` test (#34) * Move and modify test * variable name change --------- Co-authored-by: Dusan <dusan.nosovic@ethernal.tech> * Fix bridge e2e tests (#33) * Spin up bridge in bridge e2e tests * Remove unused param * Check if bridge is enabled when creating state sync relayer * Remove bridge non native ERC20 token test case * Logs * Fix segmentation fault * Remove logs * small fix * small fix * Deploy root erc20 token to the rootchain * Initialize CheckpointManager * Reduce default stake amount * TestE2E_Bridge_Transfers_AccessLists fix * Minor fixes * Fix TestE2E_AddressLists_Bridge * Fix TestE2E_Bridge_ERC721Transfer and TestE2E_Bridge_ERC1155Transfer * Fix TestE2E_Bridge_RootchainTokensTransfers * Premine fix * Reduce DefaultStake --------- Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech> * Fix local deployment scripts (#40) * Fix cluster script * Fix docker local deployment * Rename (rootchain to bridge in command outputs) * Minor change --------- Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> * test fix * Remove unnecessary forks (#42) * Remove leftover * Use in-house built event tracker (#41) * Use ethernal's event tracker * Remove log * EventTracker config in one struct * Comments fix --------- Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> * baseFeeConfig as condition for london fork (#43) * baseFeeConfig as condition for london fork * lint fix * comment fix * Update command/genesis/polybft_params.go Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com> * deleted unnecessary if * e2e test fix * Linter fix * Add base-fee-config to e2e tests where needed * Add SetBaseFeeConfig to the legacy e2e framework * Remove leftover * Provide non-validator account as receiver of native tokens in TestE2E_Consensus_MintableERC20NativeToken --------- Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com> Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech> Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com>
bane
added a commit
that referenced
this pull request
Mar 14, 2024
* Deploy Network * Add Permissions * Minor changes * Concurrency change * Destroy Network * Minor changes * Minor changes * Fix commit sha * Minor changes * Add Tests * Disable Tests temporarily * Nightly Build * Minor fixes * Big changes * Minor changes * Minor changes * Minor changes * Notification fixes * Notification changes * Minor changes * Permissions fixes * Minor changes * Notification changes * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new flag to
genesiscommand which represents an address of the owner/admin ofNativeERC20token onblade, and owner/admin ofStakeManagercontract which can whitelist new validators.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing