Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibaba SDK SSM #317

Merged
merged 16 commits into from
Aug 12, 2024
Merged

Alibaba SDK SSM #317

merged 16 commits into from
Aug 12, 2024

Conversation

oliverbundalo
Copy link

Description

Alibaba cloud SSM implementation with their SDK OOS service.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Execute command for secrets generation from local machine with alibaba-ssm config.

Copy link

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

secrets/alibaba/alibaba_ssm.go Outdated Show resolved Hide resolved
secrets/alibaba/alibaba_ssm.go Outdated Show resolved Hide resolved
secrets/alibaba/alibaba_ssm.go Outdated Show resolved Hide resolved
@oliverbundalo oliverbundalo merged commit c9e9d37 into develop Aug 12, 2024
10 checks passed
@oliverbundalo oliverbundalo deleted the alibaba-sdk branch August 12, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants