Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace armon dependency with hashicorp #400

Merged
merged 1 commit into from
Oct 4, 2024
Merged

replace armon dependency with hashicorp #400

merged 1 commit into from
Oct 4, 2024

Conversation

oliverbundalo
Copy link

Description

Dependency armon -> hashicorp due to github repo URL change. However we still have armon as an indirect dependency since DataDog and go-ibft dependencies use it.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@oliverbundalo oliverbundalo added the dependencies Pull requests that update a dependency file label Oct 4, 2024
@oliverbundalo oliverbundalo self-assigned this Oct 4, 2024
@oliverbundalo oliverbundalo merged commit 216b6a8 into develop Oct 4, 2024
10 checks passed
@oliverbundalo oliverbundalo deleted the replace-armon-dependency branch October 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@dusannosovic-ethernal dusannosovic-ethernal Awaiting requested review from dusannosovic-ethernal

Assignees

@oliverbundalo oliverbundalo

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverbundalo @Stefan-Ethernal @goran-ethernal