Introduce zero address check to IsValidAddress
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusannosovic-ethernal
requested review from
Stefan-Ethernal and
goran-ethernal
goran-ethernal
previously approved these changes
Dec 14, 2023
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Stefan-Ethernal
changed the title
IsValidAddress
Stefan-Ethernal
previously approved these changes
Dec 15, 2023
command/bridge/premine/params.go
Outdated
| stakedAmount string | ||
| premineAmount string | ||
|
|
||
| nonStakedValue *big.Int |
There was a problem hiding this comment.
Suggested change
| nonStakedValue *big.Int | |
| premineAmoountValue *big.Int |
There was a problem hiding this comment.
Stefan-Ethernal
approved these changes
Dec 15, 2023
goran-ethernal
approved these changes
Dec 15, 2023
bane
added a commit
that referenced
this pull request
Mar 14, 2024
* Deploy Network * Add Permissions * Minor changes * Concurrency change * Destroy Network * Minor changes * Minor changes * Fix commit sha * Minor changes * Add Tests * Disable Tests temporarily * Nightly Build * Minor fixes * Big changes * Minor changes * Minor changes * Minor changes * Notification fixes * Notification changes * Minor changes * Permissions fixes * Minor changes * Notification changes * Minor changes * Display commit on notifications * Minor changes * Minor fixes * Logs notification fixes * Minor changes * Minor changes * Minor changes * Notifications fixes * Minor changes * Update actions version * Deployment fixes * Minor changes * Minor changes * Build repository fixes * Load Test notification text changes * EIP-1559; Check if the network is already deployed; Restore Blade Data * Notifications fixes; Pass blade_repository when deploying the network * Terraform fixes * Minor changes * Minor changes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Notification fixes * Restore data fixes * Fix condition * Fix the RPC URL when the network is already deployed * Fix the RPC URL when the network is already deployed * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fix condition * Fixed when the network is first time deploying * Fixed upload logs * Fix: null URL if the network is destroyed but the state file exists * Main notification changes * Fix RPC URL; Fix Logs and Data upload * Minor fix * Minor fix * Notification fixes * Deploy fixes * Big changes * Condition fixes * Version changes * Test fixes * Change golangci-lint-action source * Change ec2-github-runner version; Always execute Build Blade * Minor changes * Lint fixes * Nightly test * Minor fixes * Fix Linter bug * Release changes * goreleaser fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR include additional check for zeroAddress in
types.IsValidAddressChanges include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing