GeneralStateTests/stMemoryTest/bufferSrcOffset.json test fix #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcOffset.json to fail. ReturnDataCopy did not treat as error when return address did not have enough space to receive the data, eventually not initiating rollback in a test.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Stefan-Ethernal
previously approved these changes
Feb 1, 2024
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
goran-ethernal
approved these changes
Feb 1, 2024
Stefan-Ethernal
changed the base branch from
develop
to
fix/bufferSrcOffset-evm-test
Stefan-Ethernal
merged commit ad51046
into
Ethernal-Tech:fix/bufferSrcOffset-evm-test
4 of 7 checks passed
11 tasks
Stefan-Ethernal
added a commit
that referenced
this pull request
Feb 2, 2024
* GeneralStateTests/stMemoryTest/bufferSrcOffset.json test fix (#84) * Resolving an issue that caused GeneralStateTests/stMemoryTest/bufferSrcOffset.json to fail. ReturnDataCopy did not treat as error when return address did not have enough space to receive the data, eventually not initiating rollback in a test. * Update state/runtime/evm/instructions.go Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * Update state/runtime/evm/instructions_test.go Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * Fixing typo detected by linter. --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * Linter fix --------- Co-authored-by: cokicm <mita.cokic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReturnDataCopy did not treat as error when return address did not have enough space to receive the data, eventually not initiating rollback in a test.
Description
Covering error handling when there is not enough space to receive the data with minor ReturnDataCopy refactoring and writing unit tests.
Changes include
Checklist
Testing