Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character class and level to character selection dropdown #125

Closed
ryksa92 opened this issue May 23, 2019 · 7 comments
Closed

Add character class and level to character selection dropdown #125

ryksa92 opened this issue May 23, 2019 · 7 comments

Comments

@ryksa92
Copy link

ryksa92 commented May 23, 2019

Hello.

Could you add more character related information to the list, when I choose my character inventory? I mean, it only shows my character names, but would be nice to see the character level and class name.

Thanks for your work. :)

@EtienneLamoureux
Copy link
Owner

EtienneLamoureux commented May 23, 2019

We can consider this, it doesn't seem too unreasonable.

@EtienneLamoureux EtienneLamoureux changed the title Feature request: character information. Add character level (and class?) to character selection dropdown May 23, 2019
@ryksa92
Copy link
Author

ryksa92 commented May 23, 2019

Thank you. :)

@hguy
Copy link
Collaborator

hguy commented Jun 10, 2019

With the build "Character Edit" this is done !

@EtienneLamoureux
Copy link
Owner

Right. I'll document and close

@EtienneLamoureux EtienneLamoureux self-assigned this Jun 10, 2019
@EtienneLamoureux EtienneLamoureux changed the title Add character level (and class?) to character selection dropdown Add character class and level to character selection dropdown Jun 10, 2019
@EtienneLamoureux
Copy link
Owner

EtienneLamoureux commented Jun 22, 2019

Dropdown should read as follow, to remain consistent with the multiplayer display of character names: <char>, <class> - Level: <level>.

The current challenge implementing this solution is that since we don't necessarily load all characters when first opening the vault, the current dropdown is simply populated by reading the character's folder name on the disk, and not by the game data. See TQData#GetCharacterList

@hguy
Copy link
Collaborator

hguy commented Jul 12, 2019

Dropdown should read as follow, to remain consistent with the multiplayer display of character names: <char>, <class> - Level: <level>.

The current challenge implementing this solution is that since we don't necessarily load all characters when first opening the vault, the current dropdown is simply populated by reading the character's folder name on the disk, and not by the game data. See TQData#GetCharacterList

That mean we have to accept to read all characters data to achieve this.

@EtienneLamoureux
Copy link
Owner

Or only do that when we have the character data loaded. Either refresh the dropdown on character load or implement a different dropdown population logic when pre-loading all characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants