Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of negative bonuses when listing item stats #246

Closed
afjback opened this issue Oct 23, 2019 · 3 comments
Closed

Fix display of negative bonuses when listing item stats #246

afjback opened this issue Oct 23, 2019 · 3 comments
Labels
bug

Comments

@afjback
Copy link
Contributor

afjback commented Oct 23, 2019

negative.zip
neg1-or8
neg2-or8
@EtienneLamoureux EtienneLamoureux changed the title Wrong render of negative item stats Fix rendering of negative bonuses when listing item stats Oct 23, 2019
@EtienneLamoureux EtienneLamoureux changed the title Fix rendering of negative bonuses when listing item stats Fix display of negative bonuses when listing item stats Oct 23, 2019
@hguy
Copy link
Collaborator

hguy commented Oct 24, 2019

this should be fixed by #248

@afjback
Copy link
Contributor Author

afjback commented Dec 1, 2019 •
edited
Loading

still there :(
negative.zip
negative-again-or8

@hguy
Copy link
Collaborator

hguy commented Dec 1, 2019

I spot that too !
Last fix works for negative values having positive format string, it should be fix also for positive value having negative format string.

hguy added a commit to hguy/TQVaultAE that referenced this issue Dec 2, 2019
@hguy
Fix EtienneLamoureux#246 : "Dotted decimal mask" matching
9ccb927 
Ex : {0:#0.0} Health Regeneration per second
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EtienneLamoureux @hguy @afjback