Skip to content

Commit

Permalink
update React.FC and defaultProps recommendations
Browse files Browse the repository at this point in the history
update React.FC and defaultProps recommendations with reference to typescript-cheatsheets/react#87
  • Loading branch information
EugeneYoona committed Feb 14, 2019
1 parent d03a82e commit 576cc41
Showing 1 changed file with 30 additions and 1 deletion.
31 changes: 30 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ The former pattern is shorter, so why would people use `React.FunctionComponent`
- If you need to use `children` property inside the function body, in the former case it has to be added explicitly. `FunctionComponent<T>` already includes the correctly typed `children` property which then doesn't have to become part of your type.
- Typing your function explicitly will also give you typechecking and autocomplete on its static properties, like `displayName`, `propTypes`, and `defaultProps`.
- _In future_, it will also set `readonly` on your props just like `React.Component<T>` does.
- HOWEVER, there are currently known issues using `defaultProps` with `React.FunctionComponent`. See [this issue for details](https://github.com/sw-yx/react-typescript-cheatsheet/issues/87) - scroll down to our `defaultProps` section for typing recommendations there.

```tsx
const Title: React.FunctionComponent<{ title: string }> = ({
Expand Down Expand Up @@ -387,9 +388,25 @@ class App extends React.Component<{

## Typing defaultProps

For Typescript 3.0+, type inference [should work](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-0.html), although [some edge cases are still problematic](https://github.com/sw-yx/react-typescript-cheatsheet/issues/61). Just type your props like normal.
For Typescript 3.0+, type inference [should work](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-0.html), although [some edge cases are still problematic](https://github.com/sw-yx/react-typescript-cheatsheet/issues/61). Just type your props like normal, except don't use `React.FC`.

```tsx
// ////////////////
// function components
// ////////////////
type Props = { age: number } & typeof defaultProps;
const defaultProps = {
who: 'Johny Five',
};

const Greet = (props: Props) => {
/*...*/
};
Greet.defaultProps = defaultProps

// ////////////////
// class components
// ////////////////
export type Props = {
name: string;
};
Expand All @@ -405,6 +422,18 @@ export class Greet extends React.Component<Props> {
// Type-checks! No type assertions needed!
let el = <Greet />;
```
<details>
<summary>Why does React.FC break defaultProps?</summary>

You can check the discussions here:

- https://medium.com/@martin_hotell/10-typescript-pro-tips-patterns-with-or-without-react-5799488d6680
- https://github.com/DefinitelyTyped/DefinitelyTyped/issues/30695
- https://github.com/sw-yx/react-typescript-cheatsheet/issues/87

This is just the current state and may be fixed in future.

</details>

<details>
<summary>Typescript 2.9 and earlier</summary>
Expand Down

0 comments on commit 576cc41

Please sign in to comment.