Fix Issue #4946 Basic folder upload for sftp electron.

[marko1616]

🚀 Basic Folder Upload Feature for SFTP in Electron

Status: Finished.

📝 Description

I have implemented a folder upload feature for the SFTP functionality within Electron. This enhancement allows users to upload entire folders, which could significantly improve the user experience for bulk file transfers.

🙏 Acknowledgments

I would like to express my sincere gratitude to all the project developers for their continued efforts and invaluable contributions. Your hard work has laid the foundation for features like this to be developed.

🚧 Next Steps

If the team agrees that this is a suitable implementation:

1. 🔍 Refinement: I will incorporate your feedback and make necessary adjustments.
2. 🧪 Testing: Further testing and validation will be conducted to ensure robustness.
3. ✅ Completion: Final touches and documentation updates.

• Ensure empty directory can be created.
• Add support for startUploadFromDragEvent .

Relative issues

#4946 #9841 #9738 #9569

Thank you for taking the time to review this PR. Your insights and suggestions will be highly appreciated!

[Eugeny]

Just a few comments, looks good otherwise!

Also, startUploadFromDragEvent would need to also support folder drop events too

[marko1616]

What do you think about making a directory as an ElectronFileUpload object? This way, we can treat a directory as a file, ensuring that even empty directories can be uploaded.

[Eugeny]

If you'd like to implement empty folder "uploading", I suggest two ways:
a) have startUploads[FromDragEvent] return (FileUpload|EmptyDirectory)[] where EmptyDirectory is { relativePath: string }
b) implement DirectoryUpload that would specify its children explicitly, this way you can also avoid the need for relativePath altogether

[marko1616]

Oaky I'v done all the feats.

[marko1616]

cc @Eugeny you can now have a final check for this pr.Thx
I've done all the necessary tests.

[Eugeny]

Looking good now, thanks!

@all-contributors please add @marko1616 for code

[allcontributors]

@Eugeny

We had trouble processing your request. Please try again later.