Fix cluster discovery process. #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoEight
force-pushed
the
yoeight/db-622-fix-cluster-discovery-process-in-the-java-client
branch
2 times, most recently
from
f219de8 to
dbde67c
Compare
YoEight
force-pushed
the
yoeight/db-622-fix-cluster-discovery-process-in-the-java-client
branch
from
dbde67c to
cdb7ac9
Compare
cdevarenne
approved these changes
Jan 29, 2024
w1am
approved these changes
Jan 30, 2024
YoEight
deleted the
yoeight/db-622-fix-cluster-discovery-process-in-the-java-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Fix cluster discovery process.
This patch addresses two issues:
The client wrongfully assumed that a connection string like
esdb+discover://{ip}:{port}was a single node connection. While wrong it doesn't really matter if the selected node was the leader. If it had another state, a node leader exception would have been raised and the client should reconnect to the leader of the cluster anyway.The other issue is far more annoying because it lead the client to rule out the leader node from the gossip seed because the client code wrongly assumed that node was from a previous connection attempt that failed.