[PERF] Use to_arrow_iter in to_arrow to avoid unnecessary array concats #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2780 will not alter performanceComparing Summary
|
daft/dataframe/dataframe.py
Outdated
| @@ -286,7 +286,9 @@ def iter_rows(self, results_buffer_size: Optional[int] = NUM_CPUS) -> Iterator[D | |||
| yield row | |||
|
|
|||
| @DataframePublicAPI | |||
| def to_arrow_iter(self, results_buffer_size: Optional[int] = 1) -> Iterator["pyarrow.RecordBatch"]: | |||
| def to_arrow_iter( | |||
| self, results_buffer_size: Optional[int] = 1, cast_tensors_to_ray_tensor_dtype: bool = False | |||
There was a problem hiding this comment.
should we document these arguments?
There was a problem hiding this comment.
Yeah good point... I kind of want to remove them at some point though they're not really useful and add a bunch of tech debt
There was a problem hiding this comment.
Actually for this case I'll make them "private" then by adding an underscore
universalmind303
approved these changes
Sep 4, 2024
jaychia
force-pushed
the
jay/use-iter-to_arrow
branch
from
3c1eade
to
3b72732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
to_arrow()to use Table.from_batches for performanceDriveby: fix args
results_buffer_sizedocumentation by using a num_cpus literal