Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update netlify publishing #2814

Merged
merged 6 commits into from
Sep 9, 2024
Merged

[CHORE] Update netlify publishing #2814

merged 6 commits into from
Sep 9, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 9, 2024 •
edited
Loading

Fixes:

  1. Fixes the conditional check on when to run publishing
  2. Checks that no warnings are emitted when building docs (otherwise it fails CI)
  3. Changes the alias so we get a unique link per-PR
  4. Disables the Gihub deploy thing

@github-actions github-actions bot added the chore label Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-2814--daft-docs-preview.netlify.app

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2814 will not alter performance

Comparing jay/netlify-build-fixes (c971679) with main (58d1856)

Summary

✅ 16 untouched benchmarks

@jaychia jaychia enabled auto-merge (squash) September 9, 2024 02:17
@jaychia jaychia added the documentation Improvements or additions to documentation label Sep 9, 2024
@jaychia jaychia merged commit 32f48de into main Sep 9, 2024
43 checks passed
@jaychia jaychia deleted the jay/netlify-build-fixes branch September 9, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaychia