Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Ray shuffle experiment #2883

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[FEAT] Ray shuffle experiment #2883

wants to merge 16 commits into from

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 22, 2024

No description provided.

Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #2883 will not alter performance

Comparing jay/shuffle-experiment (ade5e2f) with main (768f422)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 24.76636% with 322 lines in your changes missing coverage. Please review.

Project coverage is 78.39%. Comparing base (868bbfa) to head (37b1d8e).

Files with missing lines Patch % Lines
daft/runners/ray_runner.py 18.68% 161 Missing ⚠️
daft/execution/physical_plan.py 3.50% 55 Missing ⚠️
src/daft-scheduler/src/scheduler.rs 0.00% 34 Missing ⚠️
src/daft-plan/src/physical_planner/translate.rs 57.77% 19 Missing ⚠️
src/daft-plan/src/physical_ops/exchange_op.rs 0.00% 16 Missing ⚠️
daft/execution/physical_plan_shuffles.py 74.46% 12 Missing ⚠️
...sical_optimization/rules/reorder_partition_keys.rs 0.00% 12 Missing ⚠️
src/daft-plan/src/physical_plan.rs 0.00% 9 Missing ⚠️
daft/context.py 33.33% 2 Missing ⚠️
daft/runners/pyrunner.py 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
- Coverage   78.71%   78.39%   -0.33%     
==========================================
  Files         597      599       +2     
  Lines       69735    70128     +393     
==========================================
+ Hits        54895    54977      +82     
- Misses      14840    15151     +311     
Flag Coverage Δ
78.39% <24.76%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
daft/runners/runner.py 73.52% <100.00%> (+1.65%) ⬆️
src/daft-plan/src/physical_ops/mod.rs 0.00% <ø> (ø)
daft/runners/pyrunner.py 85.07% <66.66%> (-0.18%) ⬇️
src/daft-plan/src/display.rs 80.00% <0.00%> (-0.33%) ⬇️
daft/context.py 78.61% <33.33%> (+1.05%) ⬆️
src/daft-plan/src/physical_plan.rs 51.21% <0.00%> (-1.38%) ⬇️
daft/execution/physical_plan_shuffles.py 74.46% <74.46%> (ø)
...sical_optimization/rules/reorder_partition_keys.rs 75.25% <0.00%> (-4.97%) ⬇️
src/daft-plan/src/physical_ops/exchange_op.rs 0.00% <0.00%> (ø)
src/daft-plan/src/physical_planner/translate.rs 91.97% <57.77%> (-1.88%) ⬇️
... and 3 more

... and 5 files with indirect coverage changes

@jaychia jaychia changed the title [DRAFT] Ray shuffle experiment [FEAT] Ray shuffle experiment Sep 29, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant