Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enable groupby with alias for native executor #2917

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

colin-ho
Copy link
Contributor

Fixed this already for the current translation path back in #2790, doing the same for swordfish

@github-actions github-actions bot added the bug Something isn't working label Sep 25, 2024
Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #2917 will not alter performance

Comparing colin/swordfish-groupby-with-alias (aa61bcf) with main (6460a0e)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (6460a0e) to head (aa61bcf).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2917   +/-   ##
=======================================
  Coverage   78.38%   78.39%           
=======================================
  Files         596      596           
  Lines       69685    69688    +3     
=======================================
+ Hits        54625    54629    +4     
+ Misses      15060    15059    -1     
Flag Coverage Δ
78.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/daft-local-execution/src/pipeline.rs 91.44% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

@colin-ho colin-ho merged commit e52d965 into main Sep 26, 2024
40 checks passed
@colin-ho colin-ho deleted the colin/swordfish-groupby-with-alias branch September 26, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants