add multiimage tests for Crop

Evizero · Jul 4, 2018 · ed8ace8 · ed8ace8
1 parent 73669dd
commit ed8ace8
Show file tree

Hide file tree

Showing 3 changed files with 292 additions and 30 deletions.
diff --git a/src/operations/crop.jl b/src/operations/crop.jl
@@ -173,10 +173,6 @@ CropNative(indexes::Range...) = CropNative(indexes)
 
 @inline applylazy(op::CropNative, img::AbstractArray, param) = applyview(op, img, param)
 
-function applyeager(op::CropNative, img::AbstractArray, param)
-    plain_array(img[op.indexes...])
-end
-
 function applyaffineview(op::CropNative, img::AbstractArray, param)
     applyview(op, prepareaffine(img), param)
 end
@@ -519,10 +515,6 @@ end
 randparam(op::RCropRatio, imgs::Tuple) = rcropratio_indices(op, imgs[1])
 randparam(op::RCropRatio, img::AbstractArray) = rcropratio_indices(op, img)
 
-function applyeager(op::RCropRatio, img::AbstractArray, inds)
-    plain_array(applyview(op, img, inds))
-end
-
 function applylazy(op::RCropRatio, img::AbstractArray, inds)
     applyview(op, img, inds)
 end

diff --git a/src/utils.jl b/src/utils.jl
@@ -117,6 +117,7 @@ function direct_indices(::Tuple{}, ::Tuple{})
     throw(MethodError(direct_indices, ((),())))
 end
 
+# TODO: Figure out why this method exists
 function direct_indices(O::NTuple{N,IdentityRange}, I::NTuple{N,StepRange}) where N
     throw(MethodError(direct_indices, (O, I)))
 end