WIP: Update1.x #29
Closed
WIP: Update1.x #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 22, 2019 08:30
added 11 commits
January 28, 2019 16:53
|
|
Evizero
reviewed
Feb 9, 2019
| @@ -1,3 +1,3 @@ | |||
| build/ | |||
| site/ | |||
| src/generated/* | |||
| #src/generated/* # this should be removed | |||
There was a problem hiding this comment.
I have a bunch of items that will be removed when the upgrade is complete
There was a problem hiding this comment.
the thing is this causes a couple of files to be commited that shouldn't be
There was a problem hiding this comment.
Yes I am aware ... have been holding back more edits, mostly doc related.
|
@merl-dev Are you still working on this PR? |
Not presently |
|
close this by #31 Although there're some bugs need to be fixed, branch jc/1.x is now 1.x-compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will run on Julia 1.x, skipped about a dozen tests. Some thought given to performance but nothing implemented here. Will likely continue to work on it this week.