Skip to content

Commit

Permalink
Fix Base64 YAML encoding
Browse files Browse the repository at this point in the history
Because of FasterXML/jackson-dataformats-text#90
binary (Base64) data in YAML are not serialized correctly. This commit
introduces quite ugly hack that deals with it.
  • Loading branch information
mederly committed Nov 5, 2018
1 parent 51feb72 commit 6121d53
Showing 1 changed file with 37 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.evolveum.midpoint.prism.lex.json.yaml;

import com.fasterxml.jackson.core.Base64Variant;
import com.fasterxml.jackson.core.ObjectCodec;
import com.fasterxml.jackson.core.io.IOContext;
import com.fasterxml.jackson.dataformat.yaml.YAMLGenerator;
Expand All @@ -11,6 +12,7 @@

import java.io.IOException;
import java.io.Writer;
import java.util.Arrays;
import java.util.Collections;

public class MidpointYAMLGenerator extends YAMLGenerator {
Expand Down Expand Up @@ -62,4 +64,39 @@ public void newDocument() throws IOException {
_emitter.emit(new DocumentStartEvent(null, null, true, version, Collections.emptyMap()));
}

/*
* UGLY HACK - working around YAML serialization problem
* (https://github.com/FasterXML/jackson-dataformats-text/issues/90)
*
* TODO - after YAML problem is fixed, remove this code block (MID-4974)
* TODO - if upgrading YAML library before that, make sure everything works (because this code is almost literally copied from YAMLGenerator class)
*/

@Override
public void writeBinary(Base64Variant b64variant, byte[] data, int offset, int len) throws IOException
{
if (data == null) {
writeNull();
return;
}
_verifyValueWrite("write Binary value");
if (offset > 0 || (offset+len) != data.length) {
data = Arrays.copyOfRange(data, offset, offset+len);
}
_writeScalarBinaryPatched(b64variant, data);
}

private final static ImplicitTuple EXPLICIT_TAGS = new ImplicitTuple(false, false);
private final static Character STYLE_LITERAL = '|';
private final static Character STYLE_BASE64 = STYLE_LITERAL;
private void _writeScalarBinaryPatched(Base64Variant b64variant, byte[] data) throws IOException
{
String encoded = b64variant.encode(data);
_emitter.emit(new ScalarEvent(null, TAG_BINARY, EXPLICIT_TAGS, encoded,
null, null, STYLE_BASE64));
}

/*
* END OF UGLY HACK
*/
}

0 comments on commit 6121d53

Please sign in to comment.