suggested changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every call to CreateBuiltinFunction supplies an arg for it.
Looking at this again... (1) I don't think CreateBuiltinFunction should be getting into the details of what internal slots are appropriate. That should all be covered elsewhere (i.e., in 10.3). (2) I don't think 10.3 needs the table. Note that it lists [[Realm]], and the following para adds on the table for ordinary function objects, which also lists [[Realm]]. Note also that there's an earlier paragraph that lists the slots for an exotic built-in, but leaves out [[InitialName]], so we're giving mixed messages. Instead, I think 10.3 can cover it in 2 paragraphs, that concisely and (fairly) clearly specify all the internal slots for a built-in function, depending on how it's implemented.
... as that's the usual order in which they appear.
ExE-Boss
merged commit e09a329
into
ExE-Boss:editorial/create-builtin-function/fix-internal-slots-list-param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.