Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework #1

Merged
merged 23 commits into from
Sep 28, 2024
Merged

Rework #1

merged 23 commits into from
Sep 28, 2024

Conversation

Mikihero
Copy link
Collaborator

No description provided.

@Mikihero Mikihero marked this pull request as draft August 17, 2024 22:28
@Mikihero Mikihero marked this pull request as ready for review August 17, 2024 22:43
@Mikihero
Copy link
Collaborator Author

@Misfiy review my pr !!

VALERA771
VALERA771 approved these changes Aug 18, 2024
View reviewed changes
Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Hope that project is compiling and everything is working as expected

VladTheCow
VladTheCow requested changes Sep 3, 2024
View reviewed changes
Common Utilities/Config.cs Outdated Show resolved Hide resolved
Common Utilities/Config.cs Outdated Show resolved Hide resolved
Common Utilities/EventHandlers/ServerHandlers.cs Outdated Show resolved Hide resolved
Common Utilities/EventHandlers/ServerHandlers.cs Outdated Show resolved Hide resolved
Common Utilities/Plugin.cs Outdated Show resolved Hide resolved
Common Utilities/Plugin.cs Outdated Show resolved Hide resolved
@VladTheCow VladTheCow added the enhancement New feature or request label Sep 3, 2024
VladTheCow
VladTheCow requested changes Sep 3, 2024
View reviewed changes
Common Utilities/Config.cs Outdated Show resolved Hide resolved
Common Utilities/EventHandlers/ServerHandlers.cs Show resolved Hide resolved
@VladTheCow
Copy link
Member

Did you test all changes at all?

@Mikihero
Copy link
Collaborator Author

Mikihero commented Sep 8, 2024

everything before your first review was tested, everything after wasn't, if you want I can quickly check if everything is still fine

@VladTheCow
Copy link
Member

Also it will be nice if make all features disabled by default, for example, auto nuke, periodical broadcast message and etc

@Mikihero
Copy link
Collaborator Author

Also it will be nice if make all features disabled by default, for example, auto nuke, periodical broadcast message and etc

sounds good, I will get on it when I can

@Mikihero
Copy link
Collaborator Author

actually, I'll leave some features enabled like the disarmed escapes since disabling it would require me to delete that part from the config and it serves as a guide for people on how to input the values correctly

@VladTheCow VladTheCow merged commit 61ec80a into ExMod-Team:master Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Misfiy Misfiy Misfiy approved these changes

@VladTheCow VladTheCow VladTheCow approved these changes

@VALERA771 VALERA771 VALERA771 approved these changes

Assignees

@Mikihero Mikihero

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mikihero @VladTheCow @VALERA771 @Misfiy