Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The code compiles, but I haven't checked if it causes any errors. #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

The code compiles, but I haven't checked if it causes any errors. #1

wants to merge 5 commits into from
+4,116 −4,073

Conversation

Tamago4a
Copy link

  • Updated all nugets.
  • Updated all events that have changed during this time.
  • Ran through the code analyzer and fixed all syntax problems.
  • Fixed the problem with incorrect display of the number of players. Now the bot does not take into account NPCs.

Tamago4a and others added 5 commits October 19, 2024 18:01
@Tamago4a
Update README.md
fb86e3a
Revert "Update README.md"
bea8cc2 
This reverts commit fb86e3a.
The code compiles, but I haven't checked if it causes any errors.
b3addf0 
- Updated all nugets.
- Updated all events that have changed during this time.
- Ran through the code analyzer and fixed all syntax problems.
- Fixed the problem with incorrect display of the number of players. Now the bot does not take into account NPCs.
Update
03e5fd7
Update nugets
01428c0
VladTheCow
VladTheCow requested changes Dec 14, 2024
View reviewed changes
Copy link
Member

@VladTheCow VladTheCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the code style, the intend should be equal to 4

@Tamago4a
Copy link
Author

Please do not change the code style, the intend should be equal to 4

The code analyzer found this style incorrect, and I agree with it. What is "intend"?

@VladTheCow
Copy link
Member

Please do not change the code style, the intend should be equal to 4

The code analyzer found this style incorrect, and I agree with it. What is "intend"?

It's how many spaces you have to put before the code after the construction (it was 4, but you changed it to 2, which is bad)

@Tamago4a
Copy link
Author

Tamago4a commented Dec 20, 2024 •
edited
Loading

Please do not change the code style, the intend should be equal to 4

The code analyzer found this style incorrect, and I agree with it. What is "intend"?

It's how many spaces you have to put before the code after the construction (it was 4, but you changed it to 2, which is bad)

I'm afraid you're mistaken. These are not 8 spaces. These are tabs. Try to highlight these "spaces" in your browser and you'll understand. And I repeat, this was done by the code analyzer made by Microsoft developers. I think they are competent enough to know about the correctness of the code style.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladTheCow VladTheCow VladTheCow requested changes

@BoltonDev BoltonDev Awaiting requested review from BoltonDev

@VALERA771 VALERA771 Awaiting requested review from VALERA771

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tamago4a @VladTheCow