Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readded the Placing Pickup Into Pocket Dimension Event (with Yamato's Patch) #125

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SnivyFilms
Copy link

Description

Describe the changes
Adds an event, plus patches for when a pickup is placed into the Pocket Dimension, as items have 3 different tiers which determines the chance of the pickup being either placed back onto the map or outright deleted

What is the current behavior? (You can also link to an open issue here)
Current behavior follows base game, with no ability to change it

What is the new behavior? (if this is a feature change)
Adds an event for pickups being placed into the pocket dimension

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
This event and patch was taken from Exiled-Team Exiled before the huge drama, Yamato recommended. See: Exiled-Team/EXILED#2256


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible than you add the event but for when it's happened now (with -ed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants