Features.CustomStats #130
Open
Features.CustomStats #130
+242
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Events
Transpiler
API
base-game-bug
Misfiy
added
enhancement
VALERA771
approved these changes
Oct 7, 2024
Misfiy
commented
Oct 15, 2024
| /// <summary> | ||
| /// Gets or sets the maximum amount of stamina the player will have. | ||
| /// </summary> | ||
| public float CustomMaxValue { get; set; } |
There was a problem hiding this comment.
Suggested change
| public float CustomMaxValue { get; set; } | |
| public float CustomMaxValue { get; set; } = -1; |
| public class CustomStaminaStat : StaminaStat | ||
| { | ||
| /// <inheritdoc/> | ||
| public override float MaxValue => CustomMaxValue == default ? base.MaxValue : CustomMaxValue; |
There was a problem hiding this comment.
Suggested change
| public override float MaxValue => CustomMaxValue == default ? base.MaxValue : CustomMaxValue; | |
| public override float MaxValue => CustomMaxValue == -1 ? base.MaxValue : CustomMaxValue; |
| /// <param name="writer">The writer.</param> | ||
| public override void WriteValue(NetworkWriter writer) | ||
| { | ||
| if (CustomMaxValue == default) |
There was a problem hiding this comment.
Suggested change
| if (CustomMaxValue == default) | |
| if (CustomMaxValue == -1) |
| /// </summary> | ||
| /// <param name="reader">The reader.</param> | ||
| /// <returns>the float value sync to server.</returns> | ||
| public override float ReadValue(NetworkReader reader) => CustomMaxValue == default ? base.ReadValue(reader) : CurValue * CustomMaxValue; |
There was a problem hiding this comment.
Suggested change
| public override float ReadValue(NetworkReader reader) => CustomMaxValue == default ? base.ReadValue(reader) : CurValue * CustomMaxValue; | |
| public override float ReadValue(NetworkReader reader) => CustomMaxValue == -1 ? base.ReadValue(reader) : CurValue * CustomMaxValue; |
|
Thats things i think would make it able to set to 0 instead of being forced to something like 0.0001 or into the negatives which may cause issues |
Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>
louis1706
requested changes
Oct 19, 2024
| _valueDirty = false; | ||
| } | ||
|
|
||
| if (ShieldRegeneration == 0) |
There was a problem hiding this comment.
Cool be interesting to override this value
| /// <summary> | ||
| /// Fix for <see cref="CustomStaminaStat"/>. | ||
| /// </summary> | ||
| [HarmonyPatch(typeof(FpcStateProcessor), nameof(FpcStateProcessor.UpdateMovementState))] |
There was a problem hiding this comment.
I am pretty sure there a way to not having to patch this event it's also in the wrong file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Add Features.CustomStats
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Ability to set MaxStamina & MaxHumeShield
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other