-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Friendly Fire rules #37
base: dev
Are you sure you want to change the base?
Conversation
@louis1706 @Jesus-QC we should just return true directly? |
dup with #33 |
Hmm I didn't see this PR. |
If a PR with these changes already exists, this PR can possibly be closed, otherwise, Is this going to be updated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does previous pr already fix this bug ?
Description
Describe the changes
Fixes
CheckFriendlyFirePlayerRules
to account for when Friendly Fire is enabledWhat is the current behavior? (You can also link to an open issue here)
https://discord.com/channels/656673194693885975/1269192577475674213
What is the new behavior? (if this is a feature change)
Friendly Fire rules are respected.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. Only thing that will change is that Friendly Fire servers will be able to flash their teammates as they are supposed to be able to in base-game. (Just like grenades)
Other information:
I could possibly just return true instead of
HitboxIdentity.IsDamageable
as it would immediately return true anyways when FriendlyFire is enabled.Could also replace calls to
Server.FriendlyFire || CheckFriendlyFirePlayerRules
with justCheckFriendlyFirePlayerRules
, but that is up to you.Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other