Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exiled::Events] Command execution events #44

Closed
wants to merge 7 commits into from

Conversation

VALERA771
Copy link

@VALERA771 VALERA771 commented Aug 10, 2024

Description

Describe the changes
Adding events which are fired when commands executed. No more functional to make own commands with this system (args have ICommand and query args)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
Nvm, rewriting patch fixed this prob

Current tasks list:

  • Create an event and patch for RemoteAdmin commands
  • Test it
  • Create an event and patch for ClientConsole commands
  • Test it
  • Create an event and patch for GameConsole commands
  • Test it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771 VALERA771 changed the base branch from master to dev August 10, 2024 13:19
@VALERA771 VALERA771 added the help wanted Extra attention is needed label Aug 10, 2024
@VALERA771
Copy link
Author

Okay I'll rewrite it one day... maybe

@VALERA771 VALERA771 closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Events help wanted Extra attention is needed Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant