Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little StaffMessageFix #64

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Little StaffMessageFix #64

merged 4 commits into from
Aug 21, 2024

Conversation

IRacle1
Copy link

@IRacle1 IRacle1 commented Aug 14, 2024

Description

Describe the changes

  • little sendstaffmessage fix

What is the current behavior? (You can also link to an open issue here)
broke

What is the new behavior? (if this is a feature change)
repair

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706
Copy link

I need to get the error log

@IRacle1
Copy link
Author

IRacle1 commented Aug 15, 2024

*Also added SendStaffMessage method fix, pretty easy and funny(tested)

@louis1706
Copy link

#66 i fix the error no more need to revert

This reverts commit 904865e.
@IRacle1 IRacle1 changed the title Revert that Player::Get change Little StaffMessageFix Aug 16, 2024
@IRacle1 IRacle1 merged commit f1c58ff into ExMod-Team:dev Aug 21, 2024
5 checks passed
@IRacle1 IRacle1 deleted the fixes branch August 21, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants