Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXILED::API] Adding Turning On All Lights #90

Closed
wants to merge 9 commits into from

Conversation

Josephfallen
Copy link

@Josephfallen Josephfallen commented Sep 8, 2024

Description

Describe the changes
Added a way to turn on all lights - controller.ServerFlickerLights(0f)

What is the current behavior? (You can also link to an open issue here)
Non existent

What is the new behavior? (if this is a feature change)
Turns on all lights if they are disabled with TurnOffAllLights

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Sep 8, 2024
@Josephfallen Josephfallen changed the title Update Map.cs EXILED: API Update Map.cs Sep 8, 2024
@Josephfallen Josephfallen changed the title EXILED: API Update Map.cs [EXILED::API] Update Map.cs Sep 8, 2024
Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tested

EXILED/Exiled.API/Features/Map.cs Outdated Show resolved Hide resolved
@Josephfallen
Copy link
Author

@louis1706 Updated 🫡

@Josephfallen
Copy link
Author

@louis1706 Any update on this?

@Josephfallen Josephfallen changed the title [EXILED::API] Update Map.cs [EXILED::API] Adding Turning On All Lights Sep 22, 2024
@VladTheCow
Copy link
Member

PRs should target dev branch, not master

@Jesus-QC Jesus-QC changed the base branch from master to dev September 23, 2024 17:41
@Jesus-QC Jesus-QC changed the base branch from dev to master September 23, 2024 17:41
@Jesus-QC
Copy link

Yep, reimplement it taking dev as a base branch.

@Josephfallen Josephfallen closed this by deleting the head repository Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants