Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed point iterations within a physical time step for the advection term #1226

Merged
merged 47 commits into from
Oct 14, 2024
Merged

Fixed point iterations within a physical time step for the advection term #1226

merged 47 commits into from
Oct 14, 2024

Conversation

itopcuoglu
Copy link
Contributor

No description provided.

marchdf
marchdf requested changes Sep 3, 2024
View reviewed changes
amr-wind/equation_systems/icns/icns_advection.H Outdated Show resolved Hide resolved
amr-wind/equation_systems/AdvOp_Godunov.H Outdated Show resolved Hide resolved
amr-wind/incflo.H Outdated Show resolved Hide resolved
amr-wind/incflo.cpp Outdated Show resolved Hide resolved
amr-wind/incflo.cpp Outdated Show resolved Hide resolved
amr-wind/utilities/console_io.cpp Outdated Show resolved Hide resolved
amr-wind/utilities/console_io.cpp Outdated Show resolved Hide resolved
amr-wind/utilities/console_io.cpp Outdated Show resolved Hide resolved
amr-wind/utilities/console_io.cpp Outdated Show resolved Hide resolved
amr-wind/utilities/console_io.cpp Show resolved Hide resolved
@itopcuoglu itopcuoglu marked this pull request as ready for review September 13, 2024 17:51
@itopcuoglu itopcuoglu requested a review from mbkuhn September 24, 2024 22:28
@mbkuhn
Copy link
Contributor

mbkuhn commented Sep 24, 2024

I don't have anything to add to Marc's remaining comments. This looks really good, I'm impressed with how simply and directly you have managed to set this up.

@marchdf marchdf mentioned this pull request Oct 9, 2024
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 9, 2024
View reviewed changes
amr-wind/utilities/console_io.H Fixed Show fixed Hide fixed
amr-wind/utilities/console_io.cpp Fixed Show fixed Hide fixed
amr-wind/utilities/console_io.cpp Fixed Show fixed Hide fixed
marchdf
marchdf reviewed Oct 9, 2024
View reviewed changes
amr-wind/incflo_advance.cpp Outdated Show resolved Hide resolved
marchdf
marchdf reviewed Oct 9, 2024
View reviewed changes
amr-wind/incflo_advance.cpp Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 9, 2024
View reviewed changes
amr-wind/incflo_advance.cpp Fixed Show fixed Hide fixed
@itopcuoglu itopcuoglu force-pushed the nonlin_dev branch 2 times, most recently from 6fb44d7 to d4de2ae Compare October 9, 2024 22:18
marchdf
marchdf reviewed Oct 10, 2024
View reviewed changes
amr-wind/incflo.H Outdated Show resolved Hide resolved
marchdf
marchdf reviewed Oct 10, 2024
View reviewed changes
amr-wind/incflo.H Outdated Show resolved Hide resolved
marchdf
marchdf reviewed Oct 10, 2024
View reviewed changes
amr-wind/incflo.cpp Outdated Show resolved Hide resolved
itopcuoglu and others added 18 commits October 14, 2024 11:42
@itopcuoglu
Increasing the number of fields in the equation_systems/test_pde.cpp …
b0a8b7d 
…unit test by 1 due to the addition of the NPH state in icns.H, which is used for advection iterations
@itopcuoglu @marchdf
Update amr-wind/equation_systems/icns/icns_advection.H
fb7d9fc 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu @marchdf
Update amr-wind/incflo_advance.cpp
710940f 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu @marchdf
Update amr-wind/incflo.H
2c8762e 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu @marchdf
Update amr-wind/incflo.H
a7a4bf7 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu @marchdf
Update amr-wind/incflo.cpp
fed93e2 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu @marchdf
Update amr-wind/incflo_advance.cpp
ec7d4b2 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu @marchdf
Update amr-wind/incflo_advance.cpp
d2dadbf 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu @marchdf
Update amr-wind/utilities/console_io.H
6b5298b 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu
const arguments for print_nonlinear_residual()
3472cca
@itopcuoglu
Ternary expression for the field state that goes into pre_advection_a…
c17d8df 
…ctions()
@itopcuoglu
Array initialization for rms_vel in console_io.cpp
cd9d165
@itopcuoglu @marchdf
Update amr-wind/utilities/console_io.cpp
d78118d 
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
@itopcuoglu
Replacing amrex::Abort() instances with AMREX_ALWAYS_ASSERT_WITH_MESS…
2d87f10 
…AGE()
@itopcuoglu
Removing outdated function prototype
195046e
@itopcuoglu @mbkuhn
Update amr-wind/incflo_advance.cpp
56d6e63 
Co-authored-by: Michael B Kuhn <31661049+mbkuhn@users.noreply.github.com>
@itopcuoglu
Renaming fixed point iteration indices
c263459
@itopcuoglu
Changing the entire naming convention to fixed_point_iterations
91fefe1
marchdf
marchdf reviewed Oct 14, 2024
View reviewed changes
amr-wind/incflo.H Outdated Show resolved Hide resolved
marchdf
marchdf reviewed Oct 14, 2024
View reviewed changes
amr-wind/incflo.H Outdated Show resolved Hide resolved
marchdf
marchdf reviewed Oct 14, 2024
View reviewed changes
amr-wind/incflo.cpp Outdated Show resolved Hide resolved
marchdf
marchdf reviewed Oct 14, 2024
View reviewed changes
amr-wind/incflo.H Outdated Show resolved Hide resolved
marchdf
marchdf reviewed Oct 14, 2024
View reviewed changes
amr-wind/incflo.H Outdated Show resolved Hide resolved
@marchdf
Copy link
Contributor

marchdf commented Oct 14, 2024

All tests pass! (well except the ones irrelevant to this PR for which I created issues).

@marchdf marchdf merged commit a6e5349 into Exawind:main Oct 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@818Nawaf 818Nawaf 818Nawaf approved these changes

@mbkuhn mbkuhn mbkuhn approved these changes

@marchdf marchdf marchdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itopcuoglu @mbkuhn @marchdf @818Nawaf