Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple errors in eta for stokes waves #1392

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Dec 6, 2024

Summary

Following these notes https://www.caee.utexas.edu/prof/kinnas/ce358/oenotes/kinnas_stokes11.pdf based on this paper https://johndfenton.com/Papers/Fenton85d-A-fifth-order-Stokes-theory-for-steady-waves.pdf

4th-order term was calculated incorrectly due to a typo.

Much bigger deal -- all of the terms proportional to eps needed to be divided by k.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

@mbkuhn mbkuhn requested a review from mpolimeno December 6, 2024 20:24
Copy link
Contributor

@mpolimeno mpolimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@mbkuhn mbkuhn changed the title fix parenthesis error in eta for stokes waves fix multiple errors in eta for stokes waves Dec 6, 2024
@mbkuhn mbkuhn force-pushed the stokes_wave_eta_fix branch from 96af655 to be5766c Compare December 10, 2024 17:19
@mbkuhn mbkuhn marked this pull request as ready for review December 10, 2024 18:19
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Dec 10, 2024

Matteo is going to do a separate PR to introduce better structure into the code, which will lead to more unit tests. For now, this is a fix that we are confident in. Will introduce diffs to the ow_stokes reg test.

@mbkuhn mbkuhn merged commit 30fc9a1 into Exawind:main Dec 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants