-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling the Tioga adaptive hole map option for the hybrid solver #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
reviewed
Jan 18, 2024
itopcuoglu
force-pushed
the
ahm_dev
branch
2 times, most recently
from
February 16, 2024 19:13
aed2ef0
to
233f537
Compare
marchdf
reviewed
Feb 16, 2024
marchdf
reviewed
Feb 29, 2024
@@ -204,6 +204,10 @@ int main(int argc, char** argv) | |||
const int nonlinear_its = node["nonlinear_iterations"] | |||
? node["nonlinear_iterations"].as<int>() | |||
: 1; | |||
const bool holemap_alg = node["use_adaptive_holemap"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holemap_alg
can we rename to is_adaptive_holemap_alg
marchdf
reviewed
Feb 29, 2024
src/OversetSimulation.h
Outdated
|
||
void set_holemap_alg(bool alg) | ||
{ | ||
m_holemap_alg = alg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m_holemap_alg
to m_is_adaptive_holemap_alg
marchdf
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.