Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing for composite bodies/abutting meshes #68

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

itopcuoglu
Copy link
Contributor

No description provided.

app/exawind/exawind.cpp Outdated Show resolved Hide resolved
src/OversetSimulation.h Outdated Show resolved Hide resolved
src/OversetSimulation.h Outdated Show resolved Hide resolved
src/OversetSimulation.h Show resolved Hide resolved
src/OversetSimulation.h Show resolved Hide resolved
@psakievich
Copy link
Contributor

What is a composite mesh in this context?

@itopcuoglu
Copy link
Contributor Author

What is a composite mesh in this context?

It is the abutting mesh. The UWyo PR called it abutting/composite meshes, so I chose to refer to it as a composite mesh in the exawind-driver.

@marchdf
Copy link
Contributor

marchdf commented Mar 18, 2024

@psakievich but if you have other suggestions or better ways of naming, we will take them.

@psakievich
Copy link
Contributor

I have just never heard them called composite meshes before, just abutting. When I hear composite I think like arbitrary elements. Composite is a much broader word than abutting so I would prefer abutting. But I'm not opposed enough to request a change. I can adjust my vernacular as well.

@itopcuoglu
Copy link
Contributor Author

I have just never heard them called composite meshes before, just abutting. When I hear composite I think like arbitrary elements. Composite is a much broader word than abutting so I would prefer abutting. But I'm not opposed enough to request a change. I can adjust my vernacular as well.

I will change it to abutting then.

@itopcuoglu itopcuoglu changed the title Parsing for composite meshes Parsing for composite bodies/abutting meshes Apr 22, 2024
@itopcuoglu itopcuoglu marked this pull request as ready for review April 25, 2024 15:51
@itopcuoglu
Copy link
Contributor Author

itopcuoglu commented Apr 25, 2024

Just to have a record of this here, the correct terminology for the feature is composite body with an abutting mesh, so the input argument has been renamed to composite_body.

pressure: 0.3
turbulent_ke: 0.7
specific_dissipation_rate: 0.7
# post_processing:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete all these commented things if we don't need them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the commented out options.

@marchdf marchdf enabled auto-merge (squash) April 30, 2024 17:27
@jrood-nrel jrood-nrel disabled auto-merge April 30, 2024 17:28
@jrood-nrel jrood-nrel merged commit f96a088 into Exawind:main Apr 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants