Adaptive hole map #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case with multiblock looks coorrect. Need to extensively test.
…with an outer/overset bc face and wall bc face -- this prevents the adaptive hole map from refining to the max number of levels. (2) Fix compiler warnings about the intstring character array buffer size.
…memory cleanup. Note: suspect small memory leak in exchangeBoxes().
…compiler define variable). Also added memory cleanup for tioga shutdown -- checked with valgrind (iblank_cell is lost but only because it is handled by nalu-wind).
…into adaptive-hole-map
…te in MeshBlock::processDonors. (2) Replace raw c-pointers for adaptive processDonors.
…into adaptive-hole-map
…ap specific functions (comms), (2) macro replacement, (3) increase max level to all full 32-bit usage, (4) add back poisson_mms.
…ction using mallinfo.
Closed
jrood-nrel
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Adaptive hole map (#14) * Fixing header of meshblock output of tecplot files. * Fix cmakelists for driver and gridgen mpi and tioga library linking. * WIP: check in the adaptive hole map source code. * Implemented adaptive hole map and initial tests for tioga test sphere case with multiblock looks coorrect. Need to extensively test. * (1) Add duplicate node check when an element has two adjoining faces with an outer/overset bc face and wall bc face -- this prevents the adaptive hole map from refining to the max number of levels. (2) Fix compiler warnings about the intstring character array buffer size. * Replaced octant pointers with std::vectors. Verified correctness and memory cleanup. Note: suspect small memory leak in exchangeBoxes(). * Reenable poisson exe by fixing the fortran MPI compling issue. * Add tioga interface function to set hole map algorithm (instead of a compiler define variable). Also added memory cleanup for tioga shutdown -- checked with valgrind (iblank_cell is lost but only because it is handled by nalu-wind). * Setting the hole map algorithm to the original for merging. * Revome old svn files. * (1) Fix while loop bug which didn't update the temp donorList candidate in MeshBlock::processDonors. (2) Replace raw c-pointers for adaptive processDonors. * Address comments from Ashesh: (1) conditionals around adaptive hole map specific functions (comms), (2) macro replacement, (3) increase max level to all full 32-bit usage, (4) add back poisson_mms. * Remove malloc.h as it's nonstandard; commented out allocated data function using mallinfo. * Replaced TIOGA_MIN and TIOGA_MAX with std::min and std::max * Overloaded CartBlock::processDonors and CartBlock::processIblank functions for ADAPTIVE_HOLEMAP * Added MPI_Finalized checks into ~MeshBlock() and ~meshblockCompInfo() --------- Co-authored-by: Andrew C Kirby <37650539+ackirby88@users.noreply.github.com>
itopcuoglu
pushed a commit
to itopcuoglu/tioga
that referenced
this pull request
Mar 11, 2024
* Fixing header of meshblock output of tecplot files. * Fix cmakelists for driver and gridgen mpi and tioga library linking. * WIP: check in the adaptive hole map source code. * Implemented adaptive hole map and initial tests for tioga test sphere case with multiblock looks coorrect. Need to extensively test. * (1) Add duplicate node check when an element has two adjoining faces with an outer/overset bc face and wall bc face -- this prevents the adaptive hole map from refining to the max number of levels. (2) Fix compiler warnings about the intstring character array buffer size. * Replaced octant pointers with std::vectors. Verified correctness and memory cleanup. Note: suspect small memory leak in exchangeBoxes(). * Reenable poisson exe by fixing the fortran MPI compling issue. * Add tioga interface function to set hole map algorithm (instead of a compiler define variable). Also added memory cleanup for tioga shutdown -- checked with valgrind (iblank_cell is lost but only because it is handled by nalu-wind). * Setting the hole map algorithm to the original for merging. * Revome old svn files. * (1) Fix while loop bug which didn't update the temp donorList candidate in MeshBlock::processDonors. (2) Replace raw c-pointers for adaptive processDonors. * Address comments from Ashesh: (1) conditionals around adaptive hole map specific functions (comms), (2) macro replacement, (3) increase max level to all full 32-bit usage, (4) add back poisson_mms. * Remove malloc.h as it's nonstandard; commented out allocated data function using mallinfo.
itopcuoglu
pushed a commit
to itopcuoglu/tioga
that referenced
this pull request
Apr 3, 2024
* Fixing header of meshblock output of tecplot files. * Fix cmakelists for driver and gridgen mpi and tioga library linking. * WIP: check in the adaptive hole map source code. * Implemented adaptive hole map and initial tests for tioga test sphere case with multiblock looks coorrect. Need to extensively test. * (1) Add duplicate node check when an element has two adjoining faces with an outer/overset bc face and wall bc face -- this prevents the adaptive hole map from refining to the max number of levels. (2) Fix compiler warnings about the intstring character array buffer size. * Replaced octant pointers with std::vectors. Verified correctness and memory cleanup. Note: suspect small memory leak in exchangeBoxes(). * Reenable poisson exe by fixing the fortran MPI compling issue. * Add tioga interface function to set hole map algorithm (instead of a compiler define variable). Also added memory cleanup for tioga shutdown -- checked with valgrind (iblank_cell is lost but only because it is handled by nalu-wind). * Setting the hole map algorithm to the original for merging. * Revome old svn files. * (1) Fix while loop bug which didn't update the temp donorList candidate in MeshBlock::processDonors. (2) Replace raw c-pointers for adaptive processDonors. * Address comments from Ashesh: (1) conditionals around adaptive hole map specific functions (comms), (2) macro replacement, (3) increase max level to all full 32-bit usage, (4) add back poisson_mms. * Remove malloc.h as it's nonstandard; commented out allocated data function using mallinfo.
itopcuoglu
pushed a commit
to itopcuoglu/tioga
that referenced
this pull request
Apr 23, 2024
* Fixing header of meshblock output of tecplot files. * Fix cmakelists for driver and gridgen mpi and tioga library linking. * WIP: check in the adaptive hole map source code. * Implemented adaptive hole map and initial tests for tioga test sphere case with multiblock looks coorrect. Need to extensively test. * (1) Add duplicate node check when an element has two adjoining faces with an outer/overset bc face and wall bc face -- this prevents the adaptive hole map from refining to the max number of levels. (2) Fix compiler warnings about the intstring character array buffer size. * Replaced octant pointers with std::vectors. Verified correctness and memory cleanup. Note: suspect small memory leak in exchangeBoxes(). * Reenable poisson exe by fixing the fortran MPI compling issue. * Add tioga interface function to set hole map algorithm (instead of a compiler define variable). Also added memory cleanup for tioga shutdown -- checked with valgrind (iblank_cell is lost but only because it is handled by nalu-wind). * Setting the hole map algorithm to the original for merging. * Revome old svn files. * (1) Fix while loop bug which didn't update the temp donorList candidate in MeshBlock::processDonors. (2) Replace raw c-pointers for adaptive processDonors. * Address comments from Ashesh: (1) conditionals around adaptive hole map specific functions (comms), (2) macro replacement, (3) increase max level to all full 32-bit usage, (4) add back poisson_mms. * Remove malloc.h as it's nonstandard; commented out allocated data function using mallinfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Adaptive Hole Map to merge into the new branch of Exawind/tioga.