-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PrimitiveSettings + 3 overloads to Primitive::Create method #2107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really think that we need to put that method to obsolete and create another struct just for containing parameters. You don't use this struct anywhere except Create method
I don't really get what's wrong using a struct to better organize parameters and objects initialization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an overload to Light::Create
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% sure but default color is not white for nw but a specific color of gray
Co-authored-by: Thunder <thundermaker300@gmail.com>
Co-authored-by: Thunder <thundermaker300@gmail.com>
No description provided.