Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autommatically find exiled version #2154

Merged
merged 10 commits into from
May 21, 2024
Merged

autommatically find exiled version #2154

merged 10 commits into from
May 21, 2024

Conversation

louis1706
Copy link
Member

No description provided.

@louis1706 louis1706 added the enhancement New feature or request label Oct 19, 2023
@louis1706 louis1706 self-assigned this Oct 20, 2023
@louis1706 louis1706 added the requires-testing Things need to be verified by an Exiled Developer/Contributor label Oct 20, 2023
@louis1706 louis1706 changed the base branch from dev to apis-rework April 5, 2024 07:01
@iamalexrouse
Copy link
Member

Testing this now.

Copy link
Member

@iamalexrouse iamalexrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Results

Test Complete by @ALEXWARELLC

Tests were completed. changes work as expected.
With RequiredExiledVersion set to new Version(8,0,0)
image

Without RequiredExiledVersion
image

Tester Notes

  • No tests were requested in PR description so tests were created based on the altered files.
  • A warn statement was added for testing purposes and are not included in autommatically find exiled version #2154.

@VladTheCow VladTheCow added tested This PR has been built and tested and does not cause any obvious errors. and removed requires-testing Things need to be verified by an Exiled Developer/Contributor labels May 19, 2024
@NaoUnderscore NaoUnderscore merged commit e1ec158 into Exiled-Team:apis-rework May 21, 2024
3 checks passed
@louis1706 louis1706 deleted the AutomaticFind-ExiledVersion branch July 10, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tested This PR has been built and tested and does not cause any obvious errors.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants