-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autommatically find exiled version #2154
Merged
NaoUnderscore
merged 10 commits into
Exiled-Team:apis-rework
from
louis1706:AutomaticFind-ExiledVersion
May 21, 2024
Merged
autommatically find exiled version #2154
NaoUnderscore
merged 10 commits into
Exiled-Team:apis-rework
from
louis1706:AutomaticFind-ExiledVersion
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis1706
added
the
requires-testing
Things need to be verified by an Exiled Developer/Contributor
label
Oct 20, 2023
Testing this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Results
Test Complete by @ALEXWARELLC
Tests were completed. changes work as expected.
With RequiredExiledVersion
set to new Version(8,0,0)
Tester Notes
- No tests were requested in PR description so tests were created based on the altered files.
- A warn statement was added for testing purposes and are not included in autommatically find exiled version #2154.
iamalexrouse
approved these changes
May 19, 2024
VladTheCow
added
tested
This PR has been built and tested and does not cause any obvious errors.
and removed
requires-testing
Things need to be verified by an Exiled Developer/Contributor
labels
May 19, 2024
VladTheCow
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
tested
This PR has been built and tested and does not cause any obvious errors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.