Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resonance] Locker API Fixes & CreatePickup Patch Changes #2737

Merged
merged 6 commits into from
Jul 19, 2024
Merged

[Resonance] Locker API Fixes & CreatePickup Patch Changes #2737

merged 6 commits into from
Jul 19, 2024

Conversation

xNexusACS
Copy link
Member

@xNexusACS xNexusACS commented Jul 19, 2024 •
edited
Loading

Fixes

  • Locker API Argument Exception Fix
  • Chamber API Argument Exception Fix
  • SpawningItem NullReference spam fix

Changes

  • Remove SpawningItemEventArgs::TargetDoor property (It was causing the NRE Spam Issue)
  • Removed all door stuff from the SpawningItem Patch (It was causing the NRE Spam Issue)

@xNexusACS xNexusACS self-assigned this Jul 19, 2024
@github-actions github-actions bot added the regarding-api An issue or PR targeting the Exiled API project label Jul 19, 2024
@xNexusACS xNexusACS marked this pull request as ready for review July 19, 2024 22:04
@xNexusACS xNexusACS added regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch labels Jul 19, 2024
@xNexusACS xNexusACS changed the title [Resonance] Locker API Fixes & CreatePickup Patch Fix [Resonance] Locker API Fixes & CreatePickup Patch Changes Jul 19, 2024
@NaoUnderscore NaoUnderscore merged commit 6db7a80 into Exiled-Team:dev Jul 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xNexusACS xNexusACS

Labels
regarding-api An issue or PR targeting the Exiled API project regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xNexusACS @NaoUnderscore