Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize contam tool #492

Merged
merged 143 commits into from
Feb 23, 2023
Merged

Optimize contam tool #492

merged 143 commits into from
Feb 23, 2023

Conversation

hover2pi
Copy link
Member

@hover2pi hover2pi commented May 10, 2021

Contam tool upgrades including:

  • multiprocessing
  • single function for all JWST instruments
  • loop vectorization
  • using pysiaf for all instrument apertures

@pep8speaks
Copy link

pep8speaks commented May 10, 2021

Hello @hover2pi, Thank you for updating !

Line 210:9: E265 block comment should start with '# '
Line 312:5: E265 block comment should start with '# '

Line 186:39: E226 missing whitespace around arithmetic operator
Line 205:90: E226 missing whitespace around arithmetic operator
Line 205:99: E226 missing whitespace around arithmetic operator
Line 215:73: E241 multiple spaces after ','
Line 215:86: E231 missing whitespace after ','
Line 371:90: E231 missing whitespace after ','
Line 555:1: E402 module level import not at top of file
Line 556:1: E402 module level import not at top of file
Line 557:1: E402 module level import not at top of file
Line 559:1: E402 module level import not at top of file
Line 560:1: E402 module level import not at top of file
Line 561:1: E402 module level import not at top of file
Line 562:1: E402 module level import not at top of file
Line 563:1: E402 module level import not at top of file
Line 564:1: E402 module level import not at top of file
Line 565:1: E402 module level import not at top of file
Line 567:1: E402 module level import not at top of file

Line 92:47: W292 no newline at end of file

Line 142:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 434:41: W292 no newline at end of file

Line 179:17: W292 no newline at end of file

Line 62:1: W293 blank line contains whitespace
Line 67:1: W293 blank line contains whitespace
Line 74:54: W291 trailing whitespace
Line 75:1: W293 blank line contains whitespace
Line 79:59: W291 trailing whitespace
Line 203:21: W605 invalid escape sequence '('
Line 203:25: W605 invalid escape sequence ')'
Line 203:57: W605 invalid escape sequence '\c'
Line 203:74: W605 invalid escape sequence '\e'
Line 209:46: W605 invalid escape sequence '('
Line 209:48: W605 invalid escape sequence '\l'
Line 209:56: W605 invalid escape sequence '\m'
Line 209:66: W605 invalid escape sequence '\h'
Line 209:79: W605 invalid escape sequence '\m'
Line 209:85: W605 invalid escape sequence ')'
Line 210:46: W605 invalid escape sequence '('
Line 210:48: W605 invalid escape sequence '\l'
Line 210:56: W605 invalid escape sequence '\m'
Line 210:66: W605 invalid escape sequence '\h'
Line 210:79: W605 invalid escape sequence '\m'
Line 210:85: W605 invalid escape sequence ')'
Line 211:46: W605 invalid escape sequence '('
Line 211:48: W605 invalid escape sequence '\l'
Line 211:56: W605 invalid escape sequence '\m'
Line 211:66: W605 invalid escape sequence '\h'
Line 211:79: W605 invalid escape sequence '\m'
Line 211:85: W605 invalid escape sequence ')'
Line 217:58: W605 invalid escape sequence '('
Line 217:62: W605 invalid escape sequence '\m'
Line 217:69: W605 invalid escape sequence '\m'
Line 217:75: W605 invalid escape sequence ')'
Line 240:1: W293 blank line contains whitespace
Line 254:1: W293 blank line contains whitespace
Line 258:77: W291 trailing whitespace
Line 425:1: W293 blank line contains whitespace
Line 552:1: W293 blank line contains whitespace
Line 562:42: E261 at least two spaces before inline comment
Line 568:1: E302 expected 2 blank lines, found 1
Line 570:57: W291 trailing whitespace
Line 571:1: W293 blank line contains whitespace
Line 579:52: E231 missing whitespace after ','
Line 584:69: E261 at least two spaces before inline comment
Line 584:69: E262 inline comment should start with '# '
Line 585:5: E265 block comment should start with '# '
Line 592:1: W293 blank line contains whitespace
Line 610:1: W293 blank line contains whitespace
Line 799:1: W293 blank line contains whitespace

Line 145:116: W291 trailing whitespace

Line 135:43: E741 ambiguous variable name 'l'
Line 156:86: W292 no newline at end of file

Line 51:5: E123 closing bracket does not match indentation of opening bracket's line
Line 84:1: E302 expected 2 blank lines, found 1

Comment last updated at 2022-04-05 18:13:12 UTC

@hover2pi hover2pi merged commit 54b5c6a into develop Feb 23, 2023
@hover2pi hover2pi deleted the optimize_contam branch February 23, 2023 16:35
@hover2pi
Copy link
Member Author

hover2pi commented Mar 3, 2023

Adding #558 to this release. Here's a reminder!

hover2pi added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants