Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

185: Add daybreak_install.sh #186

Merged
merged 17 commits into from
Jul 22, 2022
Merged

185: Add daybreak_install.sh #186

merged 17 commits into from
Jul 22, 2022

Conversation

jamesaorson
Copy link
Contributor

No description provided.

@jamesaorson jamesaorson self-assigned this Jul 14, 2022
@jamesaorson jamesaorson requested a review from a team July 14, 2022 23:50
@jamesaorson jamesaorson requested a review from a team as a code owner July 14, 2022 23:50
@jamesaorson jamesaorson linked an issue Jul 14, 2022 that may be closed by this pull request
Installation program #185
Closed
soniccyclone
soniccyclone reviewed Jul 15, 2022
View reviewed changes
daybreak_install.sh Outdated Show resolved Hide resolved
@soniccyclone
Copy link
Contributor

Only changes to README and the new daybreak_install file seem related to the issue. The other changes could be put in a separate refactoring PR.

soniccyclone
soniccyclone reviewed Jul 15, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
soniccyclone
soniccyclone reviewed Jul 15, 2022
View reviewed changes
daybreak_install.sh Outdated Show resolved Hide resolved
brandonapol
brandonapol reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@brandonapol brandonapol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for changing docker-compose.yaml's env stuff to CC then back to CC_COMPILER?

@jamesaorson
Copy link
Contributor Author

What was the reason for changing docker-compose.yaml's env stuff to CC then back to CC_COMPILER?

Something we did not need to do in this PR so we took it out

@jamesaorson jamesaorson merged commit c1be19c into main Jul 22, 2022
@jamesaorson jamesaorson deleted the 185-install branch July 22, 2022 22:14
@jamesaorson jamesaorson mentioned this pull request Jul 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonapol brandonapol brandonapol approved these changes

@soniccyclone soniccyclone soniccyclone left review comments

Assignees

@jamesaorson jamesaorson

Labels
None yet
Projects
Daybreak
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation program
3 participants
@jamesaorson @soniccyclone @brandonapol