-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use latest version of foundry tools #43
Conversation
WalkthroughThe updates include two primary changes: Firstly, the Foundry version in the GitHub Actions workflow file Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/forge-ci.yml (1 hunks)
- test/foundry/ExocoreDeployer.t.sol (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/forge-ci.yml
Additional comments not posted (1)
test/foundry/ExocoreDeployer.t.sol (1)
30-33
: New Imports AddedThe new imports include
AssetsMock.sol
,ClaimRewardMock.sol
,DelegationMock.sol
, andNonShortCircuitEndpointV2Mock.sol
. Ensure these mock contracts are correctly implemented and relevant to the tests.Verification successful
New Imports Added
The new imports include
AssetsMock.sol
,ClaimRewardMock.sol
,DelegationMock.sol
, andNonShortCircuitEndpointV2Mock.sol
. These mock contracts are correctly implemented and relevant to the tests.
AssetsMock.sol
contains methods for depositing, withdrawing, and registering assets.ClaimRewardMock.sol
includes a method for claiming rewards.DelegationMock.sol
has methods for delegating and undelegating through a client chain.NonShortCircuitEndpointV2Mock.sol
implements various functionalities related to messaging and endpoint operations.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and correctness of the new import files. # Test: Check if the new mock files exist and are correctly implemented. fd 'AssetsMock.sol' 'ClaimRewardMock.sol' 'DelegationMock.sol' 'NonShortCircuitEndpointV2Mock.sol' --exec catLength of output: 355
Script:
#!/bin/bash # Description: Verify the existence and correctness of the new import files. # Test: Check if the new mock files exist and are correctly implemented. fd -e sol 'AssetsMock.sol' -exec cat {} \; fd -e sol 'ClaimRewardMock.sol' -exec cat {} \; fd -e sol 'DelegationMock.sol' -exec cat {} \; fd -e sol 'NonShortCircuitEndpointV2Mock.sol' -exec cat {} \;Length of output: 963
Script:
#!/bin/bash # Description: Verify the existence and correctness of the new import files. # Test: Check if the new mock files exist and are correctly implemented. fd -e sol 'AssetsMock.sol' --exec cat {} \; fd -e sol 'ClaimRewardMock.sol' --exec cat {} \; fd -e sol 'DelegationMock.sol' --exec cat {} \; fd -e sol 'NonShortCircuitEndpointV2Mock.sol' --exec cat {} \;Length of output: 38085
Description
the latest version of foundry tools have brought useful features like foundry-rs/foundry#7334 (comment), which requires importing source files if we want to get its code by calling
getDeployedCode
. This PR updates foundry version used in CI tonightly
instead of specific version and fix failed tests.nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9
=>nightly
inforge-ci.yml
getDeployedCode
Summary by CodeRabbit
Chores
foundry-version
parameter in CI configuration for improved stability.Tests