Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use latest version of foundry tools #43

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

adu-web3
Copy link
Collaborator

@adu-web3 adu-web3 commented Jul 4, 2024

Description

the latest version of foundry tools have brought useful features like foundry-rs/foundry#7334 (comment), which requires importing source files if we want to get its code by calling getDeployedCode. This PR updates foundry version used in CI to nightly instead of specific version and fix failed tests.

  • foundry version nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9 => nightly in forge-ci.yml
  • import source file for getDeployedCode

Summary by CodeRabbit

  • Chores

    • Updated foundry-version parameter in CI configuration for improved stability.
  • Tests

    • Added mock implementations to test suite for enhanced coverage and reliability.

Copy link
Contributor

coderabbitai bot commented Jul 4, 2024

Walkthrough

The updates include two primary changes: Firstly, the Foundry version in the GitHub Actions workflow file .github/workflows/forge-ci.yml is updated to use the generic nightly tag, ensuring it always points to the latest nightly build. Secondly, the test/foundry/ExocoreDeployer.t.sol file now imports various mock implementations, likely to facilitate more comprehensive testing.

Changes

File Summary
.github/workflows/forge-ci.yml Updated foundry-version from a specific nightly version to nightly to continuously integrate the latest nightly builds.
test/foundry/ExocoreDeployer.t.sol Added imports for mock implementations (AssetsMock.sol, ClaimRewardMock.sol, DelegationMock.sol), and NonShortCircuitEndpointV2Mock.

Poem

In the realm of nightly skies,
Forge updates, no surprise,
Mocks to test, they join the fold,
Ensuring code remains bold.
A rabbit's touch in every line,
Making sure the tests align.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a0d05f3 and c27ef82.

Files selected for processing (2)
  • .github/workflows/forge-ci.yml (1 hunks)
  • test/foundry/ExocoreDeployer.t.sol (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/forge-ci.yml
Additional comments not posted (1)
test/foundry/ExocoreDeployer.t.sol (1)

30-33: New Imports Added

The new imports include AssetsMock.sol, ClaimRewardMock.sol, DelegationMock.sol, and NonShortCircuitEndpointV2Mock.sol. Ensure these mock contracts are correctly implemented and relevant to the tests.

Verification successful

New Imports Added

The new imports include AssetsMock.sol, ClaimRewardMock.sol, DelegationMock.sol, and NonShortCircuitEndpointV2Mock.sol. These mock contracts are correctly implemented and relevant to the tests.

  • AssetsMock.sol contains methods for depositing, withdrawing, and registering assets.
  • ClaimRewardMock.sol includes a method for claiming rewards.
  • DelegationMock.sol has methods for delegating and undelegating through a client chain.
  • NonShortCircuitEndpointV2Mock.sol implements various functionalities related to messaging and endpoint operations.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence and correctness of the new import files.

# Test: Check if the new mock files exist and are correctly implemented.
fd 'AssetsMock.sol' 'ClaimRewardMock.sol' 'DelegationMock.sol' 'NonShortCircuitEndpointV2Mock.sol' --exec cat

Length of output: 355


Script:

#!/bin/bash
# Description: Verify the existence and correctness of the new import files.

# Test: Check if the new mock files exist and are correctly implemented.
fd -e sol 'AssetsMock.sol' -exec cat {} \;
fd -e sol 'ClaimRewardMock.sol' -exec cat {} \;
fd -e sol 'DelegationMock.sol' -exec cat {} \;
fd -e sol 'NonShortCircuitEndpointV2Mock.sol' -exec cat {} \;

Length of output: 963


Script:

#!/bin/bash
# Description: Verify the existence and correctness of the new import files.

# Test: Check if the new mock files exist and are correctly implemented.
fd -e sol 'AssetsMock.sol' --exec cat {} \;
fd -e sol 'ClaimRewardMock.sol' --exec cat {} \;
fd -e sol 'DelegationMock.sol' --exec cat {} \;
fd -e sol 'NonShortCircuitEndpointV2Mock.sol' --exec cat {} \;

Length of output: 38085

@adu-web3 adu-web3 merged commit bd86040 into ExocoreNetwork:main Jul 5, 2024
5 checks passed
@adu-web3 adu-web3 deleted the use-latest-foundry branch July 5, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants