Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DerivationPath predicate using Symbol.toStringTag getter #128

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: DerivationPath predicate using Symbol.toStringTag getter #128

merged 2 commits into from
Jul 30, 2024

Conversation

sparten11740
Copy link
Contributor

This fixes the isDerivationPath predicate by using the correct Symbol.toStringTag getter syntax. Keeping the previous check for backwards compat as well.

@sparten11740 sparten11740 self-assigned this Jul 30, 2024
@sparten11740 sparten11740 requested a review from kewde July 30, 2024 10:13
@sparten11740 sparten11740 merged commit 4590f79 into master Jul 30, 2024
7 checks passed
@sparten11740 sparten11740 deleted the sparten11740/fix/derivation-path-check branch July 30, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvayngrib mvayngrib mvayngrib approved these changes

@diegomura diegomura Awaiting requested review from diegomura diegomura is a code owner

@kewde kewde Awaiting requested review from kewde

Assignees

@sparten11740 sparten11740

Labels
key-identifier library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparten11740 @mvayngrib