refactor(keychain): drop unused getPrivateHDKey "exportPrivate" param #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoskichel
requested review from
kewde,
diegomura and
mvayngrib
as code owners
marcoskichel
changed the title
marcoskichel
deleted the
kichelm/keychain/refactor-export-private-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As noticed by @633kh4ck in this comment, the
exportPrivateparameter is unused bygetPrivateHDKey, so not really necessary.The presence of this parameter also gives a false sense of security as devs looking at the current usage, since we don't have type validations when consuming that method, might assume that omitting that flag would avoid the private keys from being returned, which is not the case.