Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add script to gen prod lockfile #9

Merged
merged 3 commits into from
Nov 20, 2023
Merged

chore: add script to gen prod lockfile #9

merged 3 commits into from
Nov 20, 2023

Conversation

mvayngrib
Copy link
Collaborator

@mvayngrib mvayngrib commented Nov 20, 2023

strips devDependencies everywhere and updates yarn.lock. Unfortunately yarn --production doesn't do this. Leaves changes staged

Test Plan

run ./tools/scripts/gen-prod-lock.js

check that yarn.lock is missing "eslint"

Coverage of affected packages

Note
No affected packages.

Copy link

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lint is failing, see below.

tools/scripts/gen-prod-lock.js Outdated Show resolved Hide resolved
@mvayngrib mvayngrib enabled auto-merge (squash) November 20, 2023 18:26
@mvayngrib mvayngrib merged commit 4e5689f into master Nov 20, 2023
6 of 7 checks passed
@mvayngrib mvayngrib deleted the mv/prod-lock3 branch November 20, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants