Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(generator): Add core as a dependency to generated SDKs, and remove constraints from namespace format. #18

Merged
merged 2 commits into from
Jan 17, 2023
Merged

chore(generator): Add core as a dependency to generated SDKs, and remove constraints from namespace format. #18

merged 2 commits into from
Jan 17, 2023

Conversation

OmarAlJarrah
Copy link
Contributor

Please verify that:

  • Code is up-to-date with the main branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
    -->

📝 Description

  • Add core as a dependency to generated SDKs, and remove constraints from namespace format.

🔗 Related Issues

@OmarAlJarrah OmarAlJarrah requested a review from a team as a code owner January 17, 2023 15:53
@mohnoor94 mohnoor94 merged commit acdf67d into main Jan 17, 2023
@mohnoor94 mohnoor94 deleted the OmarAlJarrah/remove_namespace_constraints_and_add_core_as_dependency_to_generated_SDKs branch January 17, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohnoor94 mohnoor94 mohnoor94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarAlJarrah @mohnoor94