Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Add support for pydantic root models. #71

Merged
merged 9 commits into from
Mar 20, 2023
Merged

chore(core): Add support for pydantic root models. #71

merged 9 commits into from
Mar 20, 2023

Conversation

OmarAlJarrah
Copy link
Contributor

@OmarAlJarrah OmarAlJarrah commented Mar 8, 2023 •
edited
Loading

📝 Description

  • Bump up fastapi-code-generator version.
  • Add new models visitor.
  • Add new templates.
  • Modify generation scripts to use new configuration.
  • Few changes to make needed data accessible.

chore(core): Add support for pydantic root models.
f8a045b 
This commit does:
* Bump up fastapi-code-generator version.
* Add new models visitor.
* Add new templates.
* Few changes to make needed data accessible.
@OmarAlJarrah OmarAlJarrah requested a review from a team as a code owner March 8, 2023 16:20
@OmarAlJarrah OmarAlJarrah self-assigned this Mar 8, 2023
@OmarAlJarrah OmarAlJarrah added Ready The pull request is ready for review and removed WIP labels Mar 9, 2023
mohnoor94
mohnoor94 previously approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mohnoor94 mohnoor94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and updated offline with Omar. Approving.

@OmarAlJarrah OmarAlJarrah merged commit f013eda into main Mar 20, 2023
@OmarAlJarrah OmarAlJarrah deleted the OmarAlJarrah/Add_support_for_pydantic_root_models branch March 20, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohnoor94 mohnoor94 mohnoor94 approved these changes

Assignees

@OmarAlJarrah OmarAlJarrah

Labels
Ready The pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarAlJarrah @mohnoor94