Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic model compatibility #1

Merged
merged 32 commits into from
Jul 6, 2023
Merged

Pydantic model compatibility #1

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
98aa248
change package name, create branch
Jun 23, 2023
8b5b2dd
remove publish and release actions
Jun 23, 2023
b18eee1
Subclass Entity to Pydantic BaseModel so it can be sent and received …
expediamatt Jun 29, 2023
53a6fe7
Add Pydantic Model conversion to Entity instead of subclassing it
expediamatt Jun 30, 2023
9a8259d
Fix accidental python requirement change
expediamatt Jun 30, 2023
de11bcf
Add Pydantic Model conversion to two DataSources, RequestSource and S…
expediamatt Jun 30, 2023
051631f
Add Pydantic Model conversion to FeatureView
expediamatt Jun 30, 2023
caf9c59
Fix some optional strings for Pydantic models
expediamatt Jun 30, 2023
623fab7
Fix small errors in DataSource and FeatureView pydantic models, do pa…
expediamatt Jun 30, 2023
83fdbc9
Add FeatureView Pydantic Model test, fix FeatureView model conversion…
expediamatt Jul 2, 2023
eae1e94
Fix Entity json encoding in FeatureView pydantic model
expediamatt Jul 2, 2023
d62e2d7
Small bug fix to make Entity list optional in FeatureViews pydantic m…
expediamatt Jul 2, 2023
66fb923
Fix Pydantic model conversions with dependencies. FeatureView depends…
expediamatt Jul 2, 2023
f0c46b6
WIP. Try adding more types to json encoder to get type checking to work.
expediamatt Jul 2, 2023
db65d80
WIP. Fixing json encoding of types
expediamatt Jul 2, 2023
db3197e
Make FeastTypes Pydantic compatible
expediamatt Jul 2, 2023
ba7bb27
Fix DatatSourceModel to SparkSource pydantic conversion and add tests
expediamatt Jul 3, 2023
4768532
Allow dtypes to be defined by strings, add more tests
expediamatt Jul 3, 2023
65f8698
Adjust schema conversion in RequestSource datasource_from_pydantic_model
expediamatt Jul 3, 2023
34109e5
Remove unnecessary properties from FeatureView pydantic model
expediamatt Jul 3, 2023
47e98b9
Remove parameters that weren't removed last time from FeatureView pyd…
expediamatt Jul 3, 2023
a6f0253
Finish linting
expediamatt Jul 3, 2023
82cdec7
Fix source choice in FeatureView pydantic model conversion to match F…
expediamatt Jul 3, 2023
89eb753
Refine FeastType json outputs
expediamatt Jul 3, 2023
f4a856e
First round of PR fixes, the small stuff
expediamatt Jul 5, 2023
493dbd4
Second round of PR fixes. Move Pydantic model conversions out of main…
expediamatt Jul 5, 2023
59e1f4e
Restore github workflow publish.yml
expediamatt Jul 6, 2023
e3fe369
Fix entity comparison in FeatureView
expediamatt Jul 6, 2023
6b9be17
Fix type checking in Pydantic models
expediamatt Jul 6, 2023
b709ce1
Update pydantic model type checking to avoid Subscripted generics error
expediamatt Jul 6, 2023
d0866d1
Small lint fix
expediamatt Jul 6, 2023
1d622e7
Restory github workflow release.yml
expediamatt Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 0 additions & 182 deletions .github/workflows/publish.yml
View file
Open in desktop
expediamatt marked this conversation as resolved.
Show resolved Hide resolved

This file was deleted.

157 changes: 0 additions & 157 deletions .github/workflows/release.yml
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions sdk/python/feast/base_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@
# limitations under the License.
from abc import ABC, abstractmethod
from datetime import datetime
from json import dumps
from typing import Dict, List, Optional, Type

from google.protobuf.json_format import MessageToJson
from proto import Message
from pydantic import BaseModel, root_validator
EXPEbdodla marked this conversation as resolved.
Show resolved Hide resolved

from feast.feature_view_projection import FeatureViewProjection
from feast.field import Field
Expand Down
Loading